Widgets in popup #2799
Open
Widgets in popup #2799
+109
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablanathtanalba
added
ui
|
Testing on a basic page with a single soundcloud embed widget: Testing on a page with many widgets, a couple of which Privacy Badger catches and replaces: https://fmarier.github.io/brave-testing/social-widgets.html |
ghostwords
reviewed
Sep 16, 2021
ablanathtanalba
force-pushed
the
widgets-in-popup
branch
from
1084e1d to
ad1265d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #2758 , Fixes #2688
This is the minimum viable option to have replaced widgets notifications in the popup, with the groundwork to build from there.
I'm not sure yet about options to en/disable the widgets from the popup vs just including the name of the replaced widget itself, or the generic version that this PR is currently at.
Here are the two states of how the popup appears when there is a replaced widget on a given page: